Great post Akos! My thoughts about code reviews are quite similar. I've seen too many folks take it as a contest rather than a collaboration.
It's incredible what a change of tone in the comments can do to the quality of collaboration in a code review. I always try to provide my input in a way that I'd like to get the input myself.
This was my motto when I changed teams. I moved from a team with clear standards to one where PRs descriptions were empty. I told my manager and myself that I wouldn't make any comments while onboarding, just ask genuine questions. Then I'd maintain my own standards and over time request others to do the same practices.
Great Post Akos !!!!
Code reviews are for collaboration and education.
Thanks a lot Petros! 😊 They are indeed!
Great post Akos! My thoughts about code reviews are quite similar. I've seen too many folks take it as a contest rather than a collaboration.
It's incredible what a change of tone in the comments can do to the quality of collaboration in a code review. I always try to provide my input in a way that I'd like to get the input myself.
Thanks for the mention as well!
Thanks Saurabh!
> I always try to provide my input in a way that I'd like to get the input myself.
This thinking alone results in a huge transformation for us and others, not just in code reviews. A great mantra to live by!
> Don’t tell, show!
This was my motto when I changed teams. I moved from a team with clear standards to one where PRs descriptions were empty. I told my manager and myself that I wouldn't make any comments while onboarding, just ask genuine questions. Then I'd maintain my own standards and over time request others to do the same practices.
Nice article, Akos. And thanks for the mention!
Thanks Fran! Yours is an excellent mindset to have. I feel most find the “honest” part difficult but it makes things soo much easier.